Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored language files to break out reports and tutorial #4312

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

randywoods
Copy link
Collaborator

The .json files have grown so large that it's time to start breaking them apart. We are starting with reports and tutorial. Each new scope that is broken out needs to be defined in app.module in the provideTranslocoScope() arguments.

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

The .json files have grown so large that it's time to start breaking them apart.  We are starting with reports and tutorial.  Each new scope that is broken out needs to be defined in app.module in the provideTranslocoScope() arguments.
@randywoods randywoods merged commit db843e6 into develop Dec 20, 2024
4 checks passed
@randywoods randywoods deleted the i18n-refactor branch December 20, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants